From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
Bernard Metzler <BMT@zurich.ibm.com>
Subject: Re: [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel
Date: Wed, 22 Sep 2010 15:18:08 -0600 [thread overview]
Message-ID: <20100922211808.GJ11157@obsidianresearch.com> (raw)
In-Reply-To: <1285189241.1849.112.camel@haakon2.linux-iscsi.org>
[cc list chopped]
On Wed, Sep 22, 2010 at 02:00:41PM -0700, Nicholas A. Bellinger wrote:
> On Wed, 2010-09-22 at 14:59 -0600, Jason Gunthorpe wrote:
> > On Wed, Sep 22, 2010 at 01:38:21PM -0700, Nicholas A. Bellinger wrote:
> >
> > > Indeed, this would clean up the explict RX/TX CRC32C case quite a
> > > bit.. Unfortuately I am too busy with other items atm to cook up
> > > this patch, but I would be happy to test it if someone wants to take
> > > it. ;)
> >
> > Do you even need to do anything at all? crc32c is provided by
> > crc32c-intel at a higher priority already, so it should be used if it
> > is available..
>
> I believe with the current libcrypto code that consumers are still
> required to explictly ask for crc32c-intel offload.
Really? It all looks OK to me.. What does your /proc/crypto say on a
system with crc32c-intel support?
Jason
next prev parent reply other threads:[~2010-09-22 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 20:30 [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel Nicholas A. Bellinger
[not found] ` <1285187425-10950-1-git-send-email-nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
2010-09-22 20:39 ` Andi Kleen
2010-09-22 20:38 ` Nicholas A. Bellinger
[not found] ` <1285187901.1849.85.camel-Y1+j5t8j3WgjMeEPmliV8E/sVC8ogwMJ@public.gmane.org>
2010-09-22 20:59 ` Jason Gunthorpe
2010-09-22 21:00 ` Nicholas A. Bellinger
2010-09-22 21:18 ` Jason Gunthorpe [this message]
2010-09-22 21:38 ` Nicholas A. Bellinger
[not found] ` <1285191511.1849.126.camel-Y1+j5t8j3WgjMeEPmliV8E/sVC8ogwMJ@public.gmane.org>
2010-09-22 22:06 ` Jason Gunthorpe
2010-09-22 22:36 ` Nicholas A. Bellinger
2010-09-23 15:31 ` Bernard Metzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922211808.GJ11157@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=BMT@zurich.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).