From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 2/2] siw: Add support for CRC32C offload instruction using libcrypto crc32c-intel Date: Wed, 22 Sep 2010 15:18:08 -0600 Message-ID: <20100922211808.GJ11157@obsidianresearch.com> References: <1285187425-10950-1-git-send-email-nab@linux-iscsi.org> <4C9A698B.90806@linux.intel.com> <1285187901.1849.85.camel@haakon2.linux-iscsi.org> <20100922205943.GI11157@obsidianresearch.com> <1285189241.1849.112.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel , netdev , linux-rdma , Bernard Metzler To: "Nicholas A. Bellinger" Return-path: Content-Disposition: inline In-Reply-To: <1285189241.1849.112.camel@haakon2.linux-iscsi.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org [cc list chopped] On Wed, Sep 22, 2010 at 02:00:41PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2010-09-22 at 14:59 -0600, Jason Gunthorpe wrote: > > On Wed, Sep 22, 2010 at 01:38:21PM -0700, Nicholas A. Bellinger wrote: > > > > > Indeed, this would clean up the explict RX/TX CRC32C case quite a > > > bit.. Unfortuately I am too busy with other items atm to cook up > > > this patch, but I would be happy to test it if someone wants to take > > > it. ;) > > > > Do you even need to do anything at all? crc32c is provided by > > crc32c-intel at a higher priority already, so it should be used if it > > is available.. > > I believe with the current libcrypto code that consumers are still > required to explictly ask for crc32c-intel offload. Really? It all looks OK to me.. What does your /proc/crypto say on a system with crc32c-intel support? Jason