From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: skb_frag_t can be smaller on small arches
Date: Thu, 23 Sep 2010 12:05:16 -0700 (PDT) [thread overview]
Message-ID: <20100923.120516.123994233.davem@davemloft.net> (raw)
In-Reply-To: <1285254414.2509.50.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 23 Sep 2010 17:06:54 +0200
> David
>
> I remember you reacted on my three years old comment about
> commit a309bb072b96bfe (Page offsets and lengths need to be __u32.)
>
> http://www.mail-archive.com/netdev@vger.kernel.org/msg43999.html
>
> Could we reconsider the thing now and allow to shrink
> sizeof(skb_shared_info) from 0x104 to 0xbc, considering nothing happened
> about scatterlist work ?
>
> This saves 128 bytes on i386 because of alignments, and can be reverted
> pretty fast if needed.
Yes, this seems reasonable. I'll probably apply this, thanks!
prev parent reply other threads:[~2010-09-23 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 15:06 [PATCH net-next-2.6] net: skb_frag_t can be smaller on small arches Eric Dumazet
2010-09-23 19:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923.120516.123994233.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).