From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Denis Kirjanov <kirjanov@gmail.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 -next] r8169: use device model DMA API
Date: Thu, 23 Sep 2010 17:23:37 +0200 [thread overview]
Message-ID: <20100923172337.3ad78757@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <AANLkTin-GPjkpp3gmS=1u5wxmxFMy_B6GL1MuDR79fDQ@mail.gmail.com>
On Thu, 23 Sep 2010 18:59:10 +0400
Denis Kirjanov <kirjanov@gmail.com> wrote:
> On Thu, Sep 23, 2010 at 4:01 PM, Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> > Use DMA API as PCI equivalents will be deprecated. This change also
> > allow to allocate with GFP_KERNEL where possible.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
>
> dma_map_single and friend can fail. Thus, we should check for a return value.
> Yes, this is not directly related to current patch, but it would be
> great to fix this.
Sure, I will another patch with fix soon.
Stanislaw
next prev parent reply other threads:[~2010-09-23 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 12:01 [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep Stanislaw Gruszka
2010-09-23 12:01 ` [PATCH 2/2 -next] r8169: use device model DMA API Stanislaw Gruszka
2010-09-23 14:59 ` Denis Kirjanov
2010-09-23 15:23 ` Stanislaw Gruszka [this message]
2010-09-23 21:20 ` [PATCH 1/2 -next] r8169: allocate with GFP_KERNEL flag when able to sleep Francois Romieu
2010-09-24 11:18 ` Stanislaw Gruszka
2010-09-24 22:24 ` Francois Romieu
2010-09-25 5:37 ` David Miller
2010-09-25 6:06 ` Eric Dumazet
2010-09-25 7:13 ` David Miller
2010-09-25 9:12 ` Eric Dumazet
2010-09-25 23:33 ` Ben Hutchings
2010-09-26 6:09 ` Eric Dumazet
2010-09-26 12:46 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923172337.3ad78757@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=kirjanov@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).