Re: [PATCHv5] net: Add batman-adv meshing protocol

[David Miller <davem@davemloft.net>]

From: Sven Eckelmann <sven.eckelmann@gmx.de>
Date: Sat, 18 Sep 2010 21:03:30 +0200

> B.A.T.M.A.N. (better approach to mobile ad-hoc networking) is a routing
> protocol for multi-hop ad-hoc mesh networks. The networks may be wired or
> wireless. See http://www.open-mesh.org/ for more information and user space
> tools.
> 
> Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>

The only thing remaining which I really don't like is this hash helper
library thing in here.

It's a terrible abstraction and very inefficient.  Iteration uses
function calls, as does removal.  Key comparisons use callbacks, via
indirection function pointers, also very inefficient.

Just use the "struct hlist_head" and "struct hlist_node" objects we
have generically already.  Inline the list iteration, as well as the
key comparisons and the node linking/unlinking.

Otherwise if you think your hash helpers are so incredibly useful,
propose for their inclusion under lib/ on linux-kernel

But frankly, I wish you a lot of luck with that. :-)