netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next2.6] drivers/net: more return operator cleanup
Date: Fri, 24 Sep 2010 19:56:43 -0700 (PDT)	[thread overview]
Message-ID: <20100924.195643.232749643.davem@davemloft.net> (raw)
In-Reply-To: <1285373014.11616.194.camel@Joe-Laptop>

From: Joe Perches <joe@perches.com>
Date: Fri, 24 Sep 2010 17:03:34 -0700

> Change "return (EXPR);" to "return EXPR;"
> 
> return is not a function, parentheses are not required.
> 
> drivers/net/wireless excluded.
> Most whitespace errors on same line as return fixed.
> 
> Done via script with some manual multi-line aligning.
> Compile tested x86 only, not all files compiled.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Joe, you're really starting to tick me off.

Why in the world are you subsuming this set of changes which Eric
Dumazet has already made already, and on top of it not giving him any
credit in the commit message?

And you're doing this after bugging the crap out of me by asking me to
hurry up with applying Eric's patch in a totally inappropriate private
email?

You have to be joking.

Look, if there is anything in my queue in patchwork, it means I am
backlogged.

And when I'm backlogged I prioritize.  And how I prioritize to get my
head back above water and on top of the queue again is my business.

The last thing you should do is try to preempt other things like
important crash fixes by asking me to hurry up with a cleanup
patch.

      reply	other threads:[~2010-09-25  2:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-23 15:40 [PATCH net-next2.6] drivers/net: return operator cleanup Eric Dumazet
2010-09-25  0:03 ` [PATCH net-next2.6] drivers/net: more " Joe Perches
2010-09-25  2:56   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100924.195643.232749643.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).