From: Jarek Poplawski <jarkao2@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out
Date: Fri, 24 Sep 2010 06:36:23 +0000 [thread overview]
Message-ID: <20100924063623.GA6359@ff.dom.local> (raw)
In-Reply-To: <1285236939-3239-1-git-send-email-xiaosuo@gmail.com>
On 2010-09-23 12:15, Changli Gao wrote:
> Since skb->destructor() is used to account socket memory, and maybe called
> before the skb is sent out, a corrupt skb maybe sent out finally.
>
> A new destructor is added into structure skb_shared_info(), and it won't
> be called until the last reference to the data of an skb is put. af_packet
> uses this destructor instead.
IMHO, we shouldn't allow for fixing the bad design of one protocol at
the expense of others by adding more and more conditionals. The proper
way of handling paged skbs (splice compatible) exists. And the current
patch doesn't even fix the problem completely against things like
pskb_expand_head or pskb_copy.
af_packet could check some flag which guarantees the queued dev can do
skb_orphan after the real xmit and copy buffers otherwise.
Jarek P.
next prev parent reply other threads:[~2010-09-24 6:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 10:15 [PATCH v3] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Changli Gao
2010-09-23 12:29 ` Eric Dumazet
2010-09-23 14:17 ` Changli Gao
2010-09-23 14:41 ` Eric Dumazet
2010-09-24 6:36 ` Jarek Poplawski [this message]
2010-09-24 7:01 ` Eric Dumazet
2010-09-27 1:25 ` David Miller
2010-09-27 5:40 ` Eric Dumazet
2010-09-27 1:22 ` David Miller
2010-09-27 5:30 ` Jarek Poplawski
2010-09-27 6:56 ` David Miller
2010-09-27 1:24 ` Changli Gao
2010-09-27 5:46 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100924063623.GA6359@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).