From: David Miller <davem@davemloft.net>
To: w@1wt.eu
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: TCP: orphans broken by RFC 2525 #2.17
Date: Sun, 26 Sep 2010 15:14:47 -0700 (PDT) [thread overview]
Message-ID: <20100926.151447.183063167.davem@davemloft.net> (raw)
In-Reply-To: <20100926191632.GB13046@1wt.eu>
From: Willy Tarreau <w@1wt.eu>
Date: Sun, 26 Sep 2010 21:16:32 +0200
> On Sun, Sep 26, 2010 at 07:40:15PM +0200, Willy Tarreau wrote:
>> 3) when an ACK comes from the other side, either it's below our last
>> seq, and we simply ignore it, just as if we were in TIME_WAIT, or
>> it is equal to the last seq and indicates that it's now safe to
>> reset ; we would then just send the RST to notify the other side
>> that the data it sent were not read. The connection can then either
>> be destroyed or put in TIME_WAIT. It's the point where the connection
>> normally switches from FIN_WAIT1 to FIN_WAIT2, since the FIN has been
>> acked. The only difference is that we don't need a FIN_WAIT2 state
>> for an orphan.
>
> In fact, the following patch seems to provide the expected result :
There is no way I'm applying this.
Pending outgoing data means nothing, and not sending out the RST is
wrong because there will be no notification to the peer that you
decided to close and ignore the data stream the peer sent, and thus
data was lost.
next prev parent reply other threads:[~2010-09-26 22:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-26 13:17 TCP: orphans broken by RFC 2525 #2.17 Willy Tarreau
2010-09-26 17:02 ` Eric Dumazet
2010-09-26 17:40 ` Willy Tarreau
2010-09-26 18:35 ` Eric Dumazet
2010-09-26 18:49 ` Willy Tarreau
2010-09-26 21:01 ` Eric Dumazet
2010-09-26 21:46 ` Willy Tarreau
2010-09-26 22:19 ` David Miller
2010-09-26 22:10 ` David Miller
2010-09-26 19:16 ` Willy Tarreau
2010-09-26 22:14 ` David Miller [this message]
2010-09-26 22:13 ` David Miller
2010-09-26 22:34 ` Willy Tarreau
2010-09-26 22:38 ` David Miller
2010-09-26 22:54 ` Willy Tarreau
2010-09-26 23:08 ` David Miller
2010-09-26 23:25 ` Willy Tarreau
2010-09-27 1:12 ` David Miller
2010-09-27 5:39 ` Willy Tarreau
2010-09-27 5:48 ` Eric Dumazet
2010-09-27 6:04 ` Willy Tarreau
2010-09-27 6:44 ` David Miller
2010-09-27 6:42 ` David Miller
2010-09-27 7:34 ` Willy Tarreau
2010-09-27 7:42 ` David Miller
2010-09-27 19:21 ` Willy Tarreau
2010-09-27 23:28 ` Herbert Xu
2010-09-28 5:12 ` Willy Tarreau
2010-09-28 5:32 ` David Miller
2010-09-28 5:37 ` Willy Tarreau
2010-09-27 9:12 ` Julian Anastasov
2010-09-27 19:24 ` Willy Tarreau
2010-09-27 20:00 ` Eric Dumazet
2010-09-28 9:01 ` Julian Anastasov
2010-09-28 9:26 ` Willy Tarreau
2010-09-27 8:02 ` Herbert Xu
2010-09-27 20:00 ` Willy Tarreau
2010-09-27 20:08 ` Rick Jones
2010-09-27 20:20 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926.151447.183063167.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).