From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3] net: af_packet: don't call tpacket_destruct_skb() until the skb is sent out Date: Sun, 26 Sep 2010 18:22:08 -0700 (PDT) Message-ID: <20100926.182208.102539866.davem@davemloft.net> References: <1285236939-3239-1-git-send-email-xiaosuo@gmail.com> <20100924063623.GA6359@ff.dom.local> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: xiaosuo@gmail.com, eric.dumazet@gmail.com, socketcan@hartkopp.net, mst@redhat.com, netdev@vger.kernel.org To: jarkao2@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:56460 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753486Ab0I0BVs (ORCPT ); Sun, 26 Sep 2010 21:21:48 -0400 In-Reply-To: <20100924063623.GA6359@ff.dom.local> Sender: netdev-owner@vger.kernel.org List-ID: From: Jarek Poplawski Date: Fri, 24 Sep 2010 06:36:23 +0000 > af_packet could check some flag which guarantees the queued dev can do > skb_orphan after the real xmit and copy buffers otherwise. Jarek, we pre-orphan SKBs in the core way before device even gets the packet. So talking about device-specific situations where this could behave differently has no sense.