From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 1/9] ibm_newemac: use free_netdev(netdev) instead of kfree() Date: Sun, 26 Sep 2010 18:54:57 -0700 (PDT) Message-ID: <20100926.185457.242128057.davem@davemloft.net> References: <1285495080-21857-1-git-send-email-segooon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jpirko-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1285495080-21857-1-git-send-email-segooon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: netdev.vger.kernel.org From: Vasiliy Kulikov Date: Sun, 26 Sep 2010 13:58:00 +0400 > Freeing netdev without free_netdev() leads to net, tx leaks. > I might lead to dereferencing freed pointer. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > @@ > struct net_device* dev; > @@ > > -kfree(dev) > +free_netdev(dev) Applied.