From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: fix rcu use in ip_route_output_slow
Date: Sun, 26 Sep 2010 19:05:31 -0700 (PDT) [thread overview]
Message-ID: <20100926.190531.233710747.davem@davemloft.net> (raw)
In-Reply-To: <1285314363.2503.12.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 24 Sep 2010 09:46:03 +0200
> [PATCH net-next-2.6] net: fix rcu use in ip_route_output_slow
>
> __in_dev_get_rtnl(dev_out) is called while RTNL is not held, thus
> triggers a lockdep fault.
>
> At this point, we only perform a raw test of dev_out->ip_ptr being NULL,
> we dont need to make sure ip_ptr cant changed right after.
>
> We can use rcu_dereference_raw() for this.
>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone!
prev parent reply other threads:[~2010-09-27 2:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 21:44 Fw: rcu warning Paul E. McKenney
2010-09-22 21:47 ` Andrew Morton
2010-09-22 23:11 ` Paul E. McKenney
2010-09-22 23:04 ` Eric Dumazet
2010-09-22 23:12 ` Paul E. McKenney
2010-09-24 7:46 ` [PATCH net-next-2.6] net: fix rcu use in ip_route_output_slow Eric Dumazet
2010-09-27 2:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926.190531.233710747.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).