From: David Miller <davem@davemloft.net>
To: JBeulich@novell.com
Cc: andrew@beldisplaytech.com, netdev@vger.kernel.org
Subject: Re: [PATCH] 3c59x: fix regression from patch "Add ethtool WOL support"
Date: Mon, 27 Sep 2010 11:08:03 -0700 (PDT) [thread overview]
Message-ID: <20100927.110803.220069414.davem@davemloft.net> (raw)
In-Reply-To: <4CA09E2D0200007800019050@vpn.id2.novell.com>
From: "Jan Beulich" <JBeulich@novell.com>
Date: Mon, 27 Sep 2010 12:37:49 +0100
> This patch (commit 690a1f2002a3091bd18a501f46c9530f10481463) added a
> new call site for acpi_set_WOL() without checking that the function is
> actually suitable to be called via
>
> vortex_set_wol+0xcd/0xe0 [3c59x]
> dev_ethtool+0xa5a/0xb70
> dev_ioctl+0x2e0/0x4b0
> T.961+0x49/0x50
> sock_ioctl+0x47/0x290
> do_vfs_ioctl+0x7f/0x340
> sys_ioctl+0x80/0xa0
> system_call_fastpath+0x16/0x1b
>
> i.e. outside of code paths run when the device is not yet enabled or
> already disabled. In particular, putting the device into D3hot is a
> pretty bad idea when it was already brought up.
>
> Furthermore, all prior callers of the function made sure they're
> actually dealing with a PCI device, while the newly added one didn't.
>
> In the same spirit, the .get_wol handler shouldn't indicate support
> for WOL for non-PCI devices.
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
Applied, thanks.
prev parent reply other threads:[~2010-09-27 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 11:37 [PATCH] 3c59x: fix regression from patch "Add ethtool WOL support" Jan Beulich
2010-09-27 18:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927.110803.220069414.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=JBeulich@novell.com \
--cc=andrew@beldisplaytech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).