From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH net-next-2.6 v2] net: sk_{detach|attach}_filter() rcu fixes
Date: Mon, 27 Sep 2010 21:51:57 -0700 (PDT) [thread overview]
Message-ID: <20100927.215157.260083160.davem@davemloft.net> (raw)
In-Reply-To: <1285603650.3017.57.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 27 Sep 2010 18:07:30 +0200
> Le lundi 27 septembre 2010 à 17:57 +0200, Eric Dumazet a écrit :
>> sk_attach_filter() is run with socket locked.
>>
>> Use the appropriate rcu_dereference_protected() instead of blocking BH,
>> and rcu_dereference_bh().
>> There is no point adding BH prevention and memory barrier.
>
> Hmm, same thing can be done in sk_detach_filter, here is a v2.
>
> Thanks
>
> [PATCH net-next-2.6 v2] net: sk_{detach|attach}_filter() rcu fixes
>
> sk_attach_filter() and sk_detach_filter() are run with socket locked.
>
> Use the appropriate rcu_dereference_protected() instead of blocking BH,
> and rcu_dereference_bh().
> There is no point adding BH prevention and memory barrier.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
prev parent reply other threads:[~2010-09-28 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 15:57 [PATCH net-next-2.6] net: sk_attach_filter() rcu fix Eric Dumazet
2010-09-27 16:07 ` [PATCH net-next-2.6 v2] net: sk_{detach|attach}_filter() rcu fixes Eric Dumazet
2010-09-28 4:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927.215157.260083160.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).