From: David Miller <davem@davemloft.net>
To: mcarlson@broadcom.com
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org,
linux-net-drivers@solarflare.com, mchan@broadcom.com
Subject: Re: [PATCH net-next-2.6 16/17] tg3: Use netif_set_real_num_{rx,tx}_queues()
Date: Mon, 27 Sep 2010 22:13:02 -0700 (PDT) [thread overview]
Message-ID: <20100927.221302.102545210.davem@davemloft.net> (raw)
In-Reply-To: <20100927214416.GA32384@mcarlson.broadcom.com>
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Mon, 27 Sep 2010 14:44:16 -0700
> On Mon, Sep 27, 2010 at 02:41:07PM -0700, Matt Carlson wrote:
>> This should be tp->irq_cnt - 1, not tp->irq_cnt. The first MSI-X vector
>> only handles link interrupts and device errors.
>
> I need to correct myself. If the irq_cnt > 1, then it needs to be
> tp->irq_cnt - 1. If the irq_cnt == 1, then it should be 1.
I fixed this when I applied Ben's patch, thanks!
next prev parent reply other threads:[~2010-09-28 5:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 18:23 [PATCH net-next-2.6 00/17] netdev: Fix queue count initialisation Ben Hutchings
2010-09-27 18:24 ` [PATCH net-next-2.6 01/17] net: Allow changing number of RX queues after device allocation Ben Hutchings
2010-09-27 18:24 ` [PATCH net-next-2.6 02/17] net: Add netif_copy_real_num_queues() for use by virtual net drivers Ben Hutchings
2010-09-27 18:25 ` [PATCH net-next-2.6 03/17] bnx2: Use netif_set_real_num_{rx,tx}_queues() Ben Hutchings
2010-09-27 18:25 ` [PATCH net-next-2.6 04/17] bnx2x: " Ben Hutchings
2010-09-28 9:26 ` Vladislav Zolotarov
2010-09-28 12:59 ` Vladislav Zolotarov
2010-09-28 17:39 ` David Miller
2010-09-27 18:25 ` [PATCH net-next-2.6 05/17] cxgb3: " Ben Hutchings
2010-09-27 18:25 ` [PATCH net-next-2.6 06/17] cxgb4: " Ben Hutchings
2010-09-27 18:26 ` [PATCH net-next-2.6 07/17] cxgb4vf: " Ben Hutchings
2010-09-27 18:27 ` [PATCH net-next-2.6 08/17] gianfar: Use netif_set_real_num_rx_queues() Ben Hutchings
2010-09-27 18:28 ` [PATCH net-next-2.6 09/17] igb: Use netif_set_real_num_{rx,tx}_queues() Ben Hutchings
2010-09-27 18:28 ` [PATCH net-next-2.6 10/17] ixgbe: " Ben Hutchings
2010-09-27 18:29 ` [PATCH net-next-2.6 11/17] mlx4_en: " Ben Hutchings
2010-09-27 18:30 ` [PATCH net-next-2.6 12/17] mv643xx_eth: " Ben Hutchings
2010-09-28 4:18 ` Lennert Buytenhek
2010-09-27 18:30 ` [PATCH net-next-2.6 13/17] myri10ge: " Ben Hutchings
2010-09-27 18:30 ` [PATCH net-next-2.6 14/17] niu: " Ben Hutchings
2010-09-27 18:31 ` [PATCH net-next-2.6 15/17] sfc: " Ben Hutchings
2010-09-27 18:32 ` [PATCH net-next-2.6 16/17] tg3: " Ben Hutchings
2010-09-27 21:41 ` Matt Carlson
2010-09-27 21:44 ` Matt Carlson
2010-09-28 5:13 ` David Miller [this message]
2010-09-27 18:32 ` [PATCH net-next-2.6 17/17] 8021q: Use netif_copy_real_num_queues() to set queue counts Ben Hutchings
2010-09-28 5:12 ` [PATCH net-next-2.6 00/17] netdev: Fix queue count initialisation David Miller
2010-09-28 12:02 ` Ben Hutchings
2010-09-28 12:07 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927.221302.102545210.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).