From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH] ip_gre: CONFIG_IPV6_MODULE support
Date: Tue, 28 Sep 2010 21:41:32 -0700 (PDT) [thread overview]
Message-ID: <20100928.214132.226782961.davem@davemloft.net> (raw)
In-Reply-To: <20100929043642.GA3660@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 29 Sep 2010 13:36:42 +0900
> On Wed, Sep 29, 2010 at 06:24:55AM +0200, Eric Dumazet wrote:
>>
>> Well, we all know icmpv6_cleanup() is not really called (or can we
>> really unload ipv6 ?).
>>
>> But unregister_icmpv6_send() should be the first call in it.
>
> Do we really need to support IPV6=m and GRE=y? It might be simpler
> to just behave as if IPv6 is off when this combination is given.
I think we should make it so that the Kconfig rule only allows
"m" or "n" for IP_GRE when IPV6=m
That's how we handle this kind of situation elsewhere, f.e. see
bonding.
Eric, please cook up a patch which does this, I think the
magic Kconfig dependency formula for this is:
depends on IPV6 || IPV6=n
Thanks!
next prev parent reply other threads:[~2010-09-29 4:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 13:01 [PATCH] ip_gre: CONFIG_IPV6_MODULE support Eric Dumazet
2010-09-20 17:06 ` David Miller
2010-09-28 8:41 ` Herbert Xu
2010-09-28 8:48 ` Eric Dumazet
2010-09-29 4:18 ` Eric Dumazet
2010-09-29 4:24 ` Eric Dumazet
2010-09-29 4:36 ` Herbert Xu
2010-09-29 4:41 ` David Miller [this message]
2010-09-29 5:38 ` David Miller
2010-09-29 6:47 ` Eric Dumazet
2010-09-29 7:25 ` David Miller
2010-09-29 7:45 ` Eric Dumazet
2010-09-29 7:57 ` Herbert Xu
2010-09-29 8:00 ` David Miller
2010-09-29 8:03 ` Herbert Xu
2010-09-29 8:22 ` Eric Dumazet
2010-09-29 7:59 ` David Miller
2010-09-29 6:24 ` Eric Dumazet
2010-09-29 7:11 ` Herbert Xu
2010-09-29 7:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928.214132.226782961.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).