From: David Miller <davem@davemloft.net>
To: gwurster@scs.carleton.ca
Cc: kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, shemminger@vyatta.com,
eric.dumazet@gmail.com, herbert@gondor.apana.org.au,
ebiederm@xmission.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-2.6 v2] IPv6: Create temporary address if none exists.
Date: Tue, 28 Sep 2010 22:25:10 -0700 (PDT) [thread overview]
Message-ID: <20100928.222510.71109554.davem@davemloft.net> (raw)
In-Reply-To: <20100927170430.GA7106@adams.ccsl.carleton.ca>
From: Glenn Wurster <gwurster@scs.carleton.ca>
Date: Mon, 27 Sep 2010 13:04:30 -0400
> If privacy extentions are enabled, but no current temporary address exists,
> then create one when we get a router advertisement.
>
> Version 2, now with 100% fewer line wraps. Thanks to David Miller for
> pointing out the line wrapping issue.
>
> Signed-off-by: Glenn Wurster <gwurster@scs.carleton.ca>
The existing code is correct from what I can tell.
Variable "create" is true when "ifp == NULL" and "valid_lft != 0"
And RFC 3041 explicitly states in section 3.3:
When a new public address is created as described in [ADDRCONF]
(because the prefix advertised does not match the prefix of any
address already assigned to the interface, and Valid Lifetime
in the option is not zero), also create a new temporary address.
Your patch is going to cause us to create a temporary address even
when valid_lft is zero, which the RFC says we should not do.
That goes against what the RFC tells us to do, so I can only conclude
that your patch is not correct.
I'm not applying this, sorry.
next prev parent reply other threads:[~2010-09-29 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 17:04 [PATCH linux-2.6 v2] IPv6: Create temporary address if none exists Glenn Wurster
2010-09-29 5:25 ` David Miller [this message]
2010-09-29 14:43 ` Brian Haley
2010-10-01 0:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100928.222510.71109554.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=gwurster@scs.carleton.ca \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=shemminger@vyatta.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).