netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH] ip_gre: CONFIG_IPV6_MODULE support
Date: Tue, 28 Sep 2010 22:38:50 -0700 (PDT)	[thread overview]
Message-ID: <20100928.223850.104051485.davem@davemloft.net> (raw)
In-Reply-To: <20100928.214132.226782961.davem@davemloft.net>

From: David Miller <davem@davemloft.net>
Date: Tue, 28 Sep 2010 21:41:32 -0700 (PDT)

> Eric, please cook up a patch which does this, I think the
> magic Kconfig dependency formula for this is:
> 
> 	depends on IPV6 || IPV6=n
> 
> Thanks!

Nevermind, I took care of it :-)

--------------------
ip_gre: Fix dependencies wrt. ipv6.

The GRE tunnel driver needs to invoke icmpv6 helpers in the
ipv6 stack when ipv6 support is enabled.

Therefore if IPV6 is enabled, we have to enforce that GRE's
enabling (modular or static) matches that of ipv6.

Reported-by: Patrick McHardy <kaber@trash.net>
Reported-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/ipv4/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 571f895..72380a3 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -217,6 +217,7 @@ config NET_IPIP
 
 config NET_IPGRE
 	tristate "IP: GRE tunnels over IP"
+	depends on IPV6 || IPV6=n
 	help
 	  Tunneling means encapsulating data of one protocol type within
 	  another protocol and sending it over a channel that understands the
-- 
1.7.3


  reply	other threads:[~2010-09-29  5:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 13:01 [PATCH] ip_gre: CONFIG_IPV6_MODULE support Eric Dumazet
2010-09-20 17:06 ` David Miller
2010-09-28  8:41 ` Herbert Xu
2010-09-28  8:48   ` Eric Dumazet
2010-09-29  4:18     ` Eric Dumazet
2010-09-29  4:24       ` Eric Dumazet
2010-09-29  4:36         ` Herbert Xu
2010-09-29  4:41           ` David Miller
2010-09-29  5:38             ` David Miller [this message]
2010-09-29  6:47               ` Eric Dumazet
2010-09-29  7:25                 ` David Miller
2010-09-29  7:45                   ` Eric Dumazet
2010-09-29  7:57                     ` Herbert Xu
2010-09-29  8:00                       ` David Miller
2010-09-29  8:03                         ` Herbert Xu
2010-09-29  8:22                           ` Eric Dumazet
2010-09-29  7:59                     ` David Miller
2010-09-29  6:24           ` Eric Dumazet
2010-09-29  7:11             ` Herbert Xu
2010-09-29  7:26               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928.223850.104051485.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).