From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] [XFRM]: Don't dereference error pointer dst1 Date: Wed, 29 Sep 2010 13:49:52 -0700 (PDT) Message-ID: <20100929.134952.15245176.davem@davemloft.net> References: <4CA3BFA3.1060204@gmail.com> <1285793113.5211.8.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: roel.kluin@gmail.com, netdev@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org To: eric.dumazet@gmail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54741 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154Ab0I2Utb (ORCPT ); Wed, 29 Sep 2010 16:49:31 -0400 In-Reply-To: <1285793113.5211.8.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Wed, 29 Sep 2010 22:45:13 +0200 > This is not a dereference, but a cast from "struct xfrm_dst *" to > "struct dst_entry *" Right, please teach whatever tool caught this that taking an address of a member of an object referenced by pointer is not an error like a true dereference is.