From: David Miller <davem@davemloft.net>
To: remi.denis-courmont@nokia.com
Cc: kumar.sanghvi@stericsson.com, netdev@vger.kernel.org,
eric.dumazet@gmail.com, gulshan.karmani@stericsson.com,
linus.walleij@stericsson.com
Subject: Re: [PATCH] Phonet: Correct header retrieval after pskb_may_pull
Date: Wed, 29 Sep 2010 19:42:09 -0700 (PDT) [thread overview]
Message-ID: <20100929.194209.200378141.davem@davemloft.net> (raw)
In-Reply-To: <201009290023.44717.remi.denis-courmont@nokia.com>
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>
Date: Wed, 29 Sep 2010 00:23:44 +0300
> On Tuesday 28 September 2010 12:10:42 ext Kumar A Sanghvi, you wrote:
>> From: Kumar Sanghvi <kumar.sanghvi@stericsson.com>
>>
>> Retrieve the header after doing pskb_may_pull since, pskb_may_pull
>> could change the buffer structure.
>>
>> This is based on the comment given by Eric Dumazet on Phonet
>> Pipe controller patch for a similar problem.
>>
>> Signed-off-by: Kumar Sanghvi <kumar.sanghvi@stericsson.com>
>> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
...
> Acked-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-09-30 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 9:10 [PATCH] Phonet: Correct header retrieval after pskb_may_pull Kumar A Sanghvi
2010-09-28 9:47 ` Eric Dumazet
2010-09-28 21:23 ` Rémi Denis-Courmont
2010-09-30 2:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929.194209.200378141.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gulshan.karmani@stericsson.com \
--cc=kumar.sanghvi@stericsson.com \
--cc=linus.walleij@stericsson.com \
--cc=netdev@vger.kernel.org \
--cc=remi.denis-courmont@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).