From: David Miller <davem@davemloft.net>
To: jgarzik@pobox.com
Cc: linux@rainbow-software.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] de2104x: disable media debug messages by default
Date: Wed, 29 Sep 2010 19:47:56 -0700 (PDT) [thread overview]
Message-ID: <20100929.194756.02282581.davem@davemloft.net> (raw)
In-Reply-To: <4CA23941.2050803@pobox.com>
From: Jeff Garzik <jgarzik@pobox.com>
Date: Tue, 28 Sep 2010 14:51:45 -0400
> On 09/28/2010 02:18 PM, Ondrej Zary wrote:
>> Print media debug messages only when HW debug is enabled.
>>
>> Signed-off-by: Ondrej Zary<linux@rainbow-software.org>
>>
>> --- linux-2.6.36-rc3-/drivers/net/tulip/de2104x.c 2010-09-28
>> --- 19:50:51.000000000 +0200
>> +++ linux-2.6.36-rc3/drivers/net/tulip/de2104x.c 2010-09-28
>> 20:05:34.000000000 +0200
>> @@ -948,8 +948,9 @@ static void de_set_media (struct de_priv
>> else
>> macmode&= ~FullDuplex;
>>
>> - if (netif_msg_link(de)) {
>> + if (netif_msg_link(de))
>> dev_info(&de->dev->dev, "set link %s\n", media_name[media]);
>> + if (netif_msg_hw(de)) {
>> dev_info(&de->dev->dev, "mode 0x%x, sia 0x%x,0x%x,0x%x,0x%x\n",
>> dr32(MacMode), dr32(SIAStatus),
>> dr32(CSR13), dr32(CSR14), dr32(CSR15));
>
> Acked-by: Jeff Garzik <jgarzik@redhat.com>
Applied to net-next-2.6
next prev parent reply other threads:[~2010-09-30 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 18:18 [PATCH] de2104x: disable media debug messages by default Ondrej Zary
2010-09-28 18:51 ` Jeff Garzik
2010-09-30 2:47 ` David Miller [this message]
2010-09-30 9:46 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929.194756.02282581.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).