netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Luethi <rl@hellgate.ch>
To: netdev@vger.kernel.org
Cc: Patrick McHardy <kaber@trash.net>
Subject: VLAN packets silently dropped in promiscuous mode
Date: Wed, 29 Sep 2010 13:37:57 +0200	[thread overview]
Message-ID: <20100929113757.GA23755@core.hellgate.ch> (raw)

I noticed packets for unknown VLANs getting silently dropped even in
promiscuous mode (this is true only for the hardware accelerated path).
netif_nit_deliver was introduced specifically to prevent that, but the
function gets called only _after_ packets from unknown VLANs have been
dropped.

Presumably this has been the case since

commit e1c096e251e52773afeffbbcb74d0a072be47ea3
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date:   Tue Jan 6 10:50:09 2009 -0800
    vlan: Add GRO interfaces

I didn't find any indication that the change in behavior is intentional. Is
it?

Roger

             reply	other threads:[~2010-09-29 11:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29 11:37 Roger Luethi [this message]
2010-09-29 17:44 ` VLAN packets silently dropped in promiscuous mode Jesse Gross
2010-09-30  8:07   ` Roger Luethi
2010-09-30  9:16     ` Eric Dumazet
2010-09-30  9:55       ` Eric Dumazet
2010-09-30 10:40         ` Eric Dumazet
2010-09-30 10:50           ` Patrick McHardy
2010-09-30 12:16             ` Eric Dumazet
2010-10-01  1:04               ` David Miller
2010-09-30 21:21     ` Jesse Gross
2010-09-30 22:04       ` Eric Dumazet
2010-10-01  2:37         ` Jesse Gross
2010-10-01  5:10           ` Eric Dumazet
2010-10-01  7:06             ` [PATCH net-next] net: add a core netdev->rx_dropped counter Eric Dumazet
2010-10-04 20:27               ` Jesse Gross
2010-10-05 21:48               ` David Miller
2010-10-01  8:41             ` VLAN packets silently dropped in promiscuous mode Eric Dumazet
2010-10-04 20:21               ` Jesse Gross
2010-10-15  9:16       ` Guillaume Gaudonville
2010-10-15 21:33         ` Jesse Gross
2010-10-25 13:48           ` Guillaume Gaudonville
2010-10-26  0:40             ` Jesse Gross
2010-10-27  8:32               ` Guillaume Gaudonville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100929113757.GA23755@core.hellgate.ch \
    --to=rl@hellgate.ch \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).