From: Flavio Leitner <fbl@redhat.com>
To: netdev@vger.kernel.org
Cc: bonding-devel@lists.sourceforge.net, Jay Vosburgh <fubar@us.ibm.com>
Subject: Re: [PATCH] bonding: fix to rejoin multicast groups immediately
Date: Wed, 29 Sep 2010 10:16:19 -0300 [thread overview]
Message-ID: <20100929131619.GA2857@redhat.com> (raw)
In-Reply-To: <1285744327-1194-1-git-send-email-fleitner@redhat.com>
forgot CC to bonding-devel@lists.sourceforge.net
On Wed, Sep 29, 2010 at 04:12:07AM -0300, Flavio Leitner wrote:
> It should rejoin multicast groups immediately when
> the failover happens to restore the multicast traffic.
>
> Signed-off-by: Flavio Leitner <fleitner@redhat.com>
> ---
> net/ipv4/igmp.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c
> index 1fdcacd..b81d674 100644
> --- a/net/ipv4/igmp.c
> +++ b/net/ipv4/igmp.c
> @@ -1257,14 +1257,14 @@ void ip_mc_rejoin_group(struct ip_mc_list *im)
> if (im->multiaddr == IGMP_ALL_HOSTS)
> return;
>
> - if (IGMP_V1_SEEN(in_dev) || IGMP_V2_SEEN(in_dev)) {
> - igmp_mod_timer(im, IGMP_Initial_Report_Delay);
> - return;
> - }
> - /* else, v3 */
> - im->crcount = in_dev->mr_qrv ? in_dev->mr_qrv :
> - IGMP_Unsolicited_Report_Count;
> - igmp_ifc_event(in_dev);
> + /* a failover is happening and switches
> + * must be notified immediately */
> + if (IGMP_V1_SEEN(in_dev))
> + igmp_send_report(in_dev, im, IGMP_HOST_MEMBERSHIP_REPORT);
> + else if (IGMP_V2_SEEN(in_dev))
> + igmp_send_report(in_dev, im, IGMPV2_HOST_MEMBERSHIP_REPORT);
> + else
> + igmp_send_report(in_dev, im, IGMPV3_HOST_MEMBERSHIP_REPORT);
> #endif
> }
> EXPORT_SYMBOL(ip_mc_rejoin_group);
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Flavio
next prev parent reply other threads:[~2010-09-29 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 7:12 [PATCH] bonding: fix to rejoin multicast groups immediately Flavio Leitner
2010-09-29 13:16 ` Flavio Leitner [this message]
2010-10-05 7:13 ` David Miller
2010-10-05 14:34 ` Flavio Leitner
2010-10-05 20:25 ` David Miller
2010-10-05 22:04 ` Flavio Leitner
2010-10-05 22:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929131619.GA2857@redhat.com \
--to=fbl@redhat.com \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).