From: David Miller <davem@davemloft.net>
To: prakity@marvell.com
Cc: netdev@vger.kernel.org, markb@marvell.com, ssanap@marvell.com
Subject: Re: [PATCH] net: pxa168_etc.c recognize additional contributors
Date: Thu, 30 Sep 2010 17:33:15 -0700 (PDT) [thread overview]
Message-ID: <20100930.173315.173856658.davem@davemloft.net> (raw)
In-Reply-To: <73276AFF-CD7C-4D61-AD6B-E0EC48C5D30C@marvell.com>
From: Philip Rakity <prakity@marvell.com>
Date: Tue, 28 Sep 2010 07:26:30 -0700
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> Signed-off-by: Sachin Sanap <ssanap@marvell.com>
> Signed-off-by: Mark Brown <markb@marvell.com>
Your patch is corrupted, did you try to edit it by hand
in something like emacs?
> diff --git a/drivers/net/pxa168_eth.c b/drivers/net/pxa168_eth.c
> index c6eeb38..0f2d41b 100644
> --- a/drivers/net/pxa168_eth.c
> +++ b/drivers/net/pxa168_eth.c
> @@ -4,8 +4,10 @@
This hunk header says there are 8 lines in the hunk beforehand
and 10 lines afterwards.
> *
> * Copyright (C) 2010 Marvell International Ltd.
> * Sachin Sanap <ssanap@marvell.com>
> + * Zhangfei Gao <zgao6@marvell.com>
> * Philip Rakity <prakity@marvell.com>
> * Mark Brown <markb@marvell.com>
> *
> * This program is free software; you can redistribute it and/or
> * modify it under the terms of the GNU General Public License
> --
> 1.6.0.4
But clearly there are 8 beforehand and 9 afterwards.
Anyways I fixed this up and added your change, but please be
more careful in the future.
prev parent reply other threads:[~2010-10-01 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 14:26 [PATCH] net: pxa168_etc.c recognize additional contributors Philip Rakity
2010-10-01 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930.173315.173856658.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=markb@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=prakity@marvell.com \
--cc=ssanap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).