netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: flameeyes@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: implement SIOCINQ ioctl() (take 3)
Date: Thu, 30 Sep 2010 17:35:57 -0700 (PDT)	[thread overview]
Message-ID: <20100930.173557.108787840.davem@davemloft.net> (raw)
In-Reply-To: <1285725095-9860-1-git-send-email-flameeyes@gmail.com>

From: Diego Elio Pettenò <flameeyes@gmail.com>
Date: Wed, 29 Sep 2010 03:51:35 +0200

> +		rc = put_user(amount, (int __user *)arg);
> +	}
> +		break;

Please put the break statement inside of the basic block.

The way you have it here the indentation looks not so nice.

  reply	other threads:[~2010-10-01  0:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  1:51 [PATCH] sctp: implement SIOCINQ ioctl() (take 3) Diego Elio Pettenò
2010-10-01  0:35 ` David Miller [this message]
2010-10-01  9:35   ` Diego Elio Pettenò
2010-10-01  9:56   ` [PATCH] sctp: implement SIOCINQ ioctl() (take 3 bis) Diego Elio Pettenò
2010-10-15 14:22     ` Diego Elio Pettenò
2010-10-15 16:59       ` David Miller
2010-10-15 17:08         ` Diego Elio Pettenò
  -- strict thread matches above, loose matches on Subject: below --
2010-09-03 13:47 [PATCH] sctp: implement SIOCINQ ioctl() (take 3) Diego Elio Pettenò
2010-09-08 20:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930.173557.108787840.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=flameeyes@gmail.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).