From: David Miller <davem@davemloft.net>
To: sathya.perla@emulex.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] be2net: add multiple RX queue support
Date: Thu, 30 Sep 2010 17:39:57 -0700 (PDT) [thread overview]
Message-ID: <20100930.173957.55855786.davem@davemloft.net> (raw)
In-Reply-To: <20100929120113.GA16206@emulex.com>
From: Sathya Perla <sathya.perla@emulex.com>
Date: Wed, 29 Sep 2010 17:31:13 +0530
> @@ -78,6 +78,13 @@ static inline char *nic_name(struct pci_dev *pdev)
> #define MCC_Q_LEN 128 /* total size not to exceed 8 pages */
> #define MCC_CQ_LEN 256
>
> +#ifdef CONFIG_PPC64 /* ppc platforms support only max of */
> +#define NUM_RSS_QS 2 /* 4 msix vectors per pci function */
> +#else
> +#define NUM_RSS_QS 4 /* BE limit is 4 queues/port */
> +#endif
If the first hunk I see in a patch is something like this, it is
not a good sign.
This is something you need to discover dynamically, and the MSI-X
vector enable functions in the kernel allow you to do this just fine.
Look at what other drivers do, they have a specific number of vectora
they try to obtain using pci_enable_msix(), and if that fails they
decrease the vector count until they are able to succeed.
next prev parent reply other threads:[~2010-10-01 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 12:01 [PATCH net-next-2.6] be2net: add multiple RX queue support Sathya Perla
2010-10-01 0:39 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-01 10:41 Sathya Perla
2010-10-04 5:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930.173957.55855786.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).