From: David Miller <davem@davemloft.net>
To: nbowler@elliptictech.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
herbert@gondor.apana.org.au, eric.dumazet@gmail.com
Subject: Re: Regression (ancient), bisected: TCP hangs with certain ESP6 SA.
Date: Thu, 30 Sep 2010 18:17:16 -0700 (PDT) [thread overview]
Message-ID: <20100930.181716.43034538.davem@davemloft.net> (raw)
In-Reply-To: <20100929142213.GA26031@elliptictech.com>
From: Nick Bowler <nbowler@elliptictech.com>
Date: Wed, 29 Sep 2010 10:22:13 -0400
> b5c15fc004ac83b7ad280acbe0fd4bbed7e2c8d4 is the first bad commit
> commit b5c15fc004ac83b7ad280acbe0fd4bbed7e2c8d4
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Thu Feb 14 23:49:37 2008 -0800
>
> [IPV6]: Fix reversed local_df test in ip6_fragment
>
> I managed to reverse the local_df test when forward-porting this
> patch so it actually makes things worse by never fragmenting at
> all.
>
> Thanks to David Stevens for testing and reporting this bug.
>
> Bill Fink pointed out that the local_df setting is also the wrong
> way around.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: David S. Miller <davem@davemloft.net>
I suspect that Herbert's change is correct, it's just that for some
reason PMTU doesn't work correctly with IPV6 for whatever reason.
That matches with your observed behavior that ping and UDP stuff
works just fine, and it's just TCP with certain ESP6 transport mode
settings.
next prev parent reply other threads:[~2010-10-01 1:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 14:22 Regression (ancient), bisected: TCP hangs with certain ESP6 SA Nick Bowler
2010-10-01 1:17 ` David Miller [this message]
2010-10-01 9:28 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930.181716.43034538.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).