From: Stephen Hemminger <shemminger@vyatta.com>
To: "Vasanthy Kolluri (vkolluri)" <vkolluri@cisco.com>
Cc: <netdev@vger.kernel.org>,
"Scott Feldman (scofeldm)" <scofeldm@cisco.com>,
"Roopa Prabhu (roprabhu)" <roprabhu@cisco.com>,
"David Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 1/2] enic: remove dead code
Date: Thu, 30 Sep 2010 11:49:58 +0900 [thread overview]
Message-ID: <20100930114958.59c438d7@s6510> (raw)
In-Reply-To: <212AA327A3557741A058E787E0618873042E0BC6@xmb-sjc-219.amer.cisco.com>
On Wed, 29 Sep 2010 17:10:00 -0700
"Vasanthy Kolluri (vkolluri)" <vkolluri@cisco.com> wrote:
> Hi Stephen,
>
>
>
> Thanks a lot for submitting this patch. However, I have got few
> concerns:
>
>
>
> 1. Need to retain vnic_dev_soft_reset and vnic_dev_soft_reset_done
> as they are used in vnic_dev_hang_reset and vnic_dev_hang_reset_done
> respectively
>
> 2. Want to retain enic_set_rss_key and enic_set_rss_cpu as we will
> be using those in the near future for adding multi rq functionality to
> enic.
>
> 3. Additional cleanup in vnic_rss.h. FYI, the struct defines in
> vnic_rss.h are currently not in use. But I retained them for the same
> reason as in #2.
Ok, but Linux tree is not the repository for "possible future enhancements".
Do it or remove it.
next prev parent reply other threads:[~2010-09-30 2:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 6:29 [PATCH net-next 1/2] enic: remove dead code Stephen Hemminger
[not found] ` <212AA327A3557741A058E787E0618873042E0BC6@xmb-sjc-219.amer.cisco.com>
2010-09-30 2:49 ` Stephen Hemminger [this message]
2010-09-30 2:57 ` David Miller
2010-09-30 5:16 ` Vasanthy Kolluri (vkolluri)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930114958.59c438d7@s6510 \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=scofeldm@cisco.com \
--cc=vkolluri@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).