* [PATCH net-next] neigh: reorder fields in struct neighbour
@ 2010-09-30 15:36 Eric Dumazet
2010-10-01 7:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2010-09-30 15:36 UTC (permalink / raw)
To: David Miller; +Cc: netdev
On 64bit arches, there are two 32bit holes that we can remove.
sizeof(struct neighbour) shrinks from 0xf8 to 0xf0 bytes
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
include/net/neighbour.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/neighbour.h b/include/net/neighbour.h
index 242879b..7d08fd1 100644
--- a/include/net/neighbour.h
+++ b/include/net/neighbour.h
@@ -94,7 +94,7 @@ struct neighbour {
struct neighbour *next;
struct neigh_table *tbl;
struct neigh_parms *parms;
- struct net_device *dev;
+ struct net_device *dev;
unsigned long used;
unsigned long confirmed;
unsigned long updated;
@@ -102,11 +102,11 @@ struct neighbour {
__u8 nud_state;
__u8 type;
__u8 dead;
+ atomic_t refcnt;
atomic_t probes;
rwlock_t lock;
unsigned char ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned long))];
struct hh_cache *hh;
- atomic_t refcnt;
int (*output)(struct sk_buff *skb);
struct sk_buff_head arp_queue;
struct timer_list timer;
@@ -163,7 +163,7 @@ struct neigh_table {
atomic_t entries;
rwlock_t lock;
unsigned long last_rand;
- struct kmem_cache *kmem_cachep;
+ struct kmem_cache *kmem_cachep;
struct neigh_statistics __percpu *stats;
struct neighbour **hash_buckets;
unsigned int hash_mask;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] neigh: reorder fields in struct neighbour
2010-09-30 15:36 [PATCH net-next] neigh: reorder fields in struct neighbour Eric Dumazet
@ 2010-10-01 7:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-01 7:37 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 30 Sep 2010 17:36:29 +0200
> On 64bit arches, there are two 32bit holes that we can remove.
>
> sizeof(struct neighbour) shrinks from 0xf8 to 0xf0 bytes
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-01 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 15:36 [PATCH net-next] neigh: reorder fields in struct neighbour Eric Dumazet
2010-10-01 7:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).