* Re: To GRO or not to GRO...
[not found] <4CA7BD60.3010501@sauce.co.nz>
@ 2010-10-03 7:18 ` "Oleg A. Arkhangelsky"
2010-10-03 7:31 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: "Oleg A. Arkhangelsky" @ 2010-10-03 7:18 UTC (permalink / raw)
To: Richard Scobie; +Cc: netdev
03.10.2010, 03:17, "Richard Scobie" <richard@sauce.co.nz>:
> In the README for ixgbe-2.1.4, is says:
>
> " Disable GRO when routing/bridging
> ---------------------------------
> Due to a known kernel issue, GRO must be turned off when
> routing/bridging.
> GRO can be turned off via ethtool."
>
This information is true for LRO, not GRO.
I believe that this appeared when ixgbe was converted from LRO
to GRO and all occurrences of LRO was blindly replaced by GRO
everywhere.
--
wbr, Oleg.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: To GRO or not to GRO...
2010-10-03 7:18 ` To GRO or not to GRO "Oleg A. Arkhangelsky"
@ 2010-10-03 7:31 ` David Miller
2010-10-04 17:48 ` Tantilov, Emil S
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-10-03 7:31 UTC (permalink / raw)
To: sysoleg; +Cc: richard, netdev
From: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
Date: Sun, 03 Oct 2010 11:18:46 +0400
>
>
> 03.10.2010, 03:17, "Richard Scobie" <richard@sauce.co.nz>:
>
>> In the README for ixgbe-2.1.4, is says:
>>
>> " Disable GRO when routing/bridging
>> ---------------------------------
>> Due to a known kernel issue, GRO must be turned off when
>> routing/bridging.
>> GRO can be turned off via ethtool."
>>
>
> This information is true for LRO, not GRO.
Right.
> I believe that this appeared when ixgbe was converted from LRO
> to GRO and all occurrences of LRO was blindly replaced by GRO
> everywhere.
Someome please submit a patch to fix this, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: To GRO or not to GRO...
2010-10-03 7:31 ` David Miller
@ 2010-10-04 17:48 ` Tantilov, Emil S
0 siblings, 0 replies; 3+ messages in thread
From: Tantilov, Emil S @ 2010-10-04 17:48 UTC (permalink / raw)
To: David Miller, sysoleg@yandex.ru
Cc: richard@sauce.co.nz, netdev@vger.kernel.org
>-----Original Message-----
>From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
>Behalf Of David Miller
>Sent: Sunday, October 03, 2010 12:31 AM
>To: sysoleg@yandex.ru
>Cc: richard@sauce.co.nz; netdev@vger.kernel.org
>Subject: Re: To GRO or not to GRO...
>
>From: "\"Oleg A. Arkhangelsky\"" <sysoleg@yandex.ru>
>Date: Sun, 03 Oct 2010 11:18:46 +0400
>
>>
>>
>> 03.10.2010, 03:17, "Richard Scobie" <richard@sauce.co.nz>:
>>
>>> In the README for ixgbe-2.1.4, is says:
>>>
>>> " Disable GRO when routing/bridging
>>> ---------------------------------
>>> Due to a known kernel issue, GRO must be turned off when
>>> routing/bridging.
>>> GRO can be turned off via ethtool."
>>>
>>
>> This information is true for LRO, not GRO.
>
>Right.
>
>> I believe that this appeared when ixgbe was converted from LRO
>> to GRO and all occurrences of LRO was blindly replaced by GRO
>> everywhere.
>
>Someome please submit a patch to fix this, thanks.
The information referenced above is from the README included with the out-of-tree ixgbe driver which we provide for download at e1000.sf.net.
The in-kernel docs are accurate AFAICT.
Thanks,
Emil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-04 17:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4CA7BD60.3010501@sauce.co.nz>
2010-10-03 7:18 ` To GRO or not to GRO "Oleg A. Arkhangelsky"
2010-10-03 7:31 ` David Miller
2010-10-04 17:48 ` Tantilov, Emil S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).