From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "ipv4: Make INET_LRO a bool instead of tristate."
Date: Sun, 03 Oct 2010 21:01:55 -0700 (PDT) [thread overview]
Message-ID: <20101003.210155.189686958.davem@davemloft.net> (raw)
In-Reply-To: <1286164495.3916.316.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 04 Oct 2010 04:54:55 +0100
> On Sun, 2010-10-03 at 19:56 -0700, David Miller wrote:
>> From: Ben Hutchings <ben@decadent.org.uk>
>> Date: Mon, 04 Oct 2010 02:37:42 +0100
>>
>> > You made the change I want to revert in response to
>> > <http://article.gmane.org/gmane.linux.kernel/825646>. The real problem
>> > with its configuration is actually that CONFIG_INET is not set but
>> > CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
>> > CONFIG_INET.
>>
>> Ben, you can't just revert this by itself.
>>
>> That knowingly breaks the build.
>>
>> If you want the tristate back, you must do it after or at the
>> same time as fixing the driver deps.
>
> The fact that the driver dependencies are broken has nothing to do with
> whether CONFIG_INET_LRO is boolean or tristate. You fixed a problem
> that didn't exist rather than the problem that did.
Oh, I see, ok I'll apply your patches thanks for explaining Ben.
prev parent reply other threads:[~2010-10-04 4:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 1:37 [PATCH 1/2] Revert "ipv4: Make INET_LRO a bool instead of tristate." Ben Hutchings
2010-10-04 1:42 ` [PATCH 2/2] netdev: Depend on INET before selecting INET_LRO Ben Hutchings
2010-10-04 2:56 ` [PATCH 1/2] Revert "ipv4: Make INET_LRO a bool instead of tristate." David Miller
2010-10-04 3:54 ` Ben Hutchings
2010-10-04 4:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003.210155.189686958.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).