From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: drosenberg@vsecurity.com, sri@us.ibm.com,
linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org,
security@kernel.org, stable@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix out-of-bounds reading in sctp_asoc_get_hmac()
Date: Sun, 03 Oct 2010 22:00:57 -0700 (PDT) [thread overview]
Message-ID: <20101003.220057.59686624.davem@davemloft.net> (raw)
In-Reply-To: <4CA65D0E.6080604@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Fri, 01 Oct 2010 18:13:34 -0400
> On 10/01/2010 05:51 PM, Dan Rosenberg wrote:
>> The sctp_asoc_get_hmac() function iterates through a peer's hmac_ids
>> array and attempts to ensure that only a supported hmac entry is
>> returned. The current code fails to do this properly - if the last id
>> in the array is out of range (greater than SCTP_AUTH_HMAC_ID_MAX), the
>> id integer remains set after exiting the loop, and the address of an
>> out-of-bounds entry will be returned and subsequently used in the
>> parent
>> function, causing potentially ugly memory corruption. This patch
>> resets
>> the id integer to 0 on encountering an invalid id so that NULL will be
>> returned after finishing the loop if no valid ids are found.
>>
>> Signed-off-by: Dan Rosenberg<drosenberg@vsecurity.com>
>
> Good catch.
>
> Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied.
prev parent reply other threads:[~2010-10-04 5:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 21:51 [PATCH] Fix out-of-bounds reading in sctp_asoc_get_hmac() Dan Rosenberg
2010-10-01 22:13 ` Vlad Yasevich
2010-10-04 5:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101003.220057.59686624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drosenberg@vsecurity.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=sri@us.ibm.com \
--cc=stable@kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).