* [PATCH net-next] cxgb4: remove a bogus PCI function number check
@ 2010-09-30 19:17 Dimitris Michailidis
2010-10-04 5:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dimitris Michailidis @ 2010-09-30 19:17 UTC (permalink / raw)
To: netdev; +Cc: Dimitris Michailidis
Remove a bogus PCI function number check from the driver's .remove
method that causes pci_release_regions not to be called for function 0
if additional functions are attached and one of them is used as primary.
Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
---
drivers/net/cxgb4/cxgb4_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/cxgb4/cxgb4_main.c b/drivers/net/cxgb4/cxgb4_main.c
index 4fb08e3..22169a7 100644
--- a/drivers/net/cxgb4/cxgb4_main.c
+++ b/drivers/net/cxgb4/cxgb4_main.c
@@ -3863,7 +3863,7 @@ static void __devexit remove_one(struct pci_dev *pdev)
pci_disable_device(pdev);
pci_release_regions(pdev);
pci_set_drvdata(pdev, NULL);
- } else if (PCI_FUNC(pdev->devfn) > 0)
+ } else
pci_release_regions(pdev);
}
--
1.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cxgb4: remove a bogus PCI function number check
2010-09-30 19:17 [PATCH net-next] cxgb4: remove a bogus PCI function number check Dimitris Michailidis
@ 2010-10-04 5:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-10-04 5:07 UTC (permalink / raw)
To: dm; +Cc: netdev
From: Dimitris Michailidis <dm@chelsio.com>
Date: Thu, 30 Sep 2010 12:17:12 -0700
> Remove a bogus PCI function number check from the driver's .remove
> method that causes pci_release_regions not to be called for function 0
> if additional functions are attached and one of them is used as primary.
>
> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-04 5:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-30 19:17 [PATCH net-next] cxgb4: remove a bogus PCI function number check Dimitris Michailidis
2010-10-04 5:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).