From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gospodarek Subject: Re: [PATCH v2] bonding: rejoin multicast groups on VLANs Date: Mon, 4 Oct 2010 09:24:10 -0400 Message-ID: <20101004132409.GA7497@gospo.rdu.redhat.com> References: <20100929131713.GB2857@redhat.com> <1285879524-7046-1-git-send-email-fleitner@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, Andy Gospodarek , bonding-devel@lists.sourceforge.net, Jay Vosburgh To: Flavio Leitner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5892 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755157Ab0JDNYV (ORCPT ); Mon, 4 Oct 2010 09:24:21 -0400 Content-Disposition: inline In-Reply-To: <1285879524-7046-1-git-send-email-fleitner@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 30, 2010 at 05:45:24PM -0300, Flavio Leitner wrote: > It fixes bonding to rejoin multicast groups added > to VLAN devices on top of bonding when a failover > happens. > > Signed-off-by: Flavio Leitner > --- > drivers/net/bonding/bond_main.c | 61 +++++++++++++++++++++++++++++++++----- > drivers/net/bonding/bonding.h | 1 + > 2 files changed, 54 insertions(+), 8 deletions(-) > [...] > @@ -944,7 +979,9 @@ static void bond_mc_swap(struct bonding *bond, struct slave *new_active, > > netdev_for_each_mc_addr(ha, bond->dev) > dev_mc_add(new_active->dev, ha->addr); > - bond_resend_igmp_join_requests(bond); > + > + /* rejoin multicast groups */ > + queue_delayed_work(bond->wq, &bond->mcast_work, 0); > } > } > I was hoping that one patch would just make the changes so retransmission was supported on VLANs and the second patch would queue the work and add the tunable for multiple retransmissions, but I guess it wasn't clear enough. I felt like that would divide the patches up into the bug-fix (VLANs + multicast not working) and the new feature (multiple retransmissions from the workqueue). I will test these out this morning and make sure things look good.