From: David Miller <davem@davemloft.net>
To: u.kleine-koenig@pengutronix.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net/phy: fix many "defined but unused" warnings
Date: Tue, 05 Oct 2010 00:36:02 -0700 (PDT) [thread overview]
Message-ID: <20101005.003602.57483854.davem@davemloft.net> (raw)
In-Reply-To: <1286185413-22924-1-git-send-email-u.kleine-koenig@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mon, 4 Oct 2010 11:43:32 +0200
> MODULE_DEVICE_TABLE only expdrivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not usedands to something if it's compiled
> for a module. So when building-in support for the phys, the
> mdio_device_id tables are unused. Marking them with __maybe_unused
> fixes the following warnings:
>
> drivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not used
> drivers/net/phy/broadcom.c:933: warning: 'broadcom_tbl' defined but not used
> drivers/net/phy/cicada.c:162: warning: 'cicada_tbl' defined but not used
> drivers/net/phy/davicom.c:222: warning: 'davicom_tbl' defined but not used
> drivers/net/phy/et1011c.c:114: warning: 'et1011c_tbl' defined but not used
> drivers/net/phy/icplus.c:137: warning: 'icplus_tbl' defined but not used
> drivers/net/phy/lxt.c:226: warning: 'lxt_tbl' defined but not used
> drivers/net/phy/marvell.c:724: warning: 'marvell_tbl' defined but not used
> drivers/net/phy/micrel.c:234: warning: 'micrel_tbl' defined but not used
> drivers/net/phy/national.c:154: warning: 'ns_tbl' defined but not used
> drivers/net/phy/qsemi.c:141: warning: 'qs6612_tbl' defined but not used
> drivers/net/phy/realtek.c:82: warning: 'realtek_tbl' defined but not used
> drivers/net/phy/smsc.c:257: warning: 'smsc_tbl' defined but not used
> drivers/net/phy/ste10Xp.c:135: warning: 'ste10Xp_tbl' defined but not used
> drivers/net/phy/vitesse.c:195: warning: 'vitesse_tbl' defined but not used
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Unfortunate but necessary for now, so applied, thanks.
Maybe we can eventually put something into MODULE_DEVICE_TABLE to add a nop-style
reference, enough to shut up the compiler but not actually compile the table into
the code.
prev parent reply other threads:[~2010-10-05 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 9:43 [PATCH 1/2] net/phy: fix many "defined but unused" warnings Uwe Kleine-König
2010-10-04 9:43 ` [PATCH 2/2] [RFC] don't let BCM63XX_PHY depend on non-existant symbol Uwe Kleine-König
2010-10-05 7:36 ` David Miller
2010-10-05 7:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005.003602.57483854.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).