From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: hadi@cyberus.ca, shemminger@vyatta.com, elendil@planet.nl,
xiaosuo@gmail.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] cls_u32: signedness bug
Date: Tue, 05 Oct 2010 00:40:01 -0700 (PDT) [thread overview]
Message-ID: <20101005.004001.214209669.davem@davemloft.net> (raw)
In-Reply-To: <20101004122836.GB5692@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Mon, 4 Oct 2010 14:28:36 +0200
> skb_headroom() is unsigned so "skb_headroom(skb) + toff" is also
> unsigned and can't be less than zero. This test was added in 66d50d25:
> "u32: negative offset fix" It was supposed to fix a regression.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> Compile tested only. Please check.
This looks correct to me, thanks for fixing this.
Applied.
prev parent reply other threads:[~2010-10-05 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 12:28 [patch] cls_u32: signedness bug Dan Carpenter
2010-10-05 7:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005.004001.214209669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=elendil@planet.nl \
--cc=error27@gmail.com \
--cc=hadi@cyberus.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).