From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, sjur.brandeland@stericsson.com
Subject: Re: [PATCH] caif: fix two caif_connect() bugs
Date: Tue, 05 Oct 2010 20:38:58 -0700 (PDT) [thread overview]
Message-ID: <20101005.203858.115928630.davem@davemloft.net> (raw)
In-Reply-To: <1286268128.2796.27.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 05 Oct 2010 10:42:08 +0200
> caif_connect() might dereference a netdevice after dev_put() it.
>
> It also doesnt check dev_get_by_index() return value and could
> dereference a NULL pointer.
>
> Fix it, using RCU to avoid taking a reference.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks Eric.
prev parent reply other threads:[~2010-10-06 3:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 8:42 [PATCH] caif: fix two caif_connect() bugs Eric Dumazet
2010-10-06 3:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101005.203858.115928630.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox