* [PATCH net-next] fib: fib_rules_cleanup can be static
@ 2010-10-05 6:14 Stephen Hemminger
2010-10-05 6:19 ` Eric Dumazet
2010-10-05 7:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2010-10-05 6:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev
fib_rules_cleanup_ups is only defined and used in one place.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/include/net/fib_rules.h 2010-10-02 14:31:52.528341728 +0900
+++ b/include/net/fib_rules.h 2010-10-02 14:31:59.890839969 +0900
@@ -106,7 +106,6 @@ static inline u32 frh_get_table(struct f
extern struct fib_rules_ops *fib_rules_register(const struct fib_rules_ops *, struct net *);
extern void fib_rules_unregister(struct fib_rules_ops *);
-extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
extern int fib_rules_lookup(struct fib_rules_ops *,
struct flowi *, int flags,
--- a/net/core/fib_rules.c 2010-10-02 14:31:52.578341727 +0900
+++ b/net/core/fib_rules.c 2010-10-02 14:32:09.850842358 +0900
@@ -144,7 +144,7 @@ fib_rules_register(const struct fib_rule
}
EXPORT_SYMBOL_GPL(fib_rules_register);
-void fib_rules_cleanup_ops(struct fib_rules_ops *ops)
+static void fib_rules_cleanup_ops(struct fib_rules_ops *ops)
{
struct fib_rule *rule, *tmp;
@@ -153,7 +153,6 @@ void fib_rules_cleanup_ops(struct fib_ru
fib_rule_put(rule);
}
}
-EXPORT_SYMBOL_GPL(fib_rules_cleanup_ops);
static void fib_rules_put_rcu(struct rcu_head *head)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fib: fib_rules_cleanup can be static
2010-10-05 6:14 [PATCH net-next] fib: fib_rules_cleanup can be static Stephen Hemminger
@ 2010-10-05 6:19 ` Eric Dumazet
2010-10-05 7:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2010-10-05 6:19 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev
Le mardi 05 octobre 2010 à 15:14 +0900, Stephen Hemminger a écrit :
> fib_rules_cleanup_ups is only defined and used in one place.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] fib: fib_rules_cleanup can be static
2010-10-05 6:14 [PATCH net-next] fib: fib_rules_cleanup can be static Stephen Hemminger
2010-10-05 6:19 ` Eric Dumazet
@ 2010-10-05 7:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-10-05 7:49 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 5 Oct 2010 15:14:17 +0900
> fib_rules_cleanup_ups is only defined and used in one place.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-05 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 6:14 [PATCH net-next] fib: fib_rules_cleanup can be static Stephen Hemminger
2010-10-05 6:19 ` Eric Dumazet
2010-10-05 7:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).