netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ipv6: make __ipv6_isatap_ifid static
@ 2010-10-05  6:17 Stephen Hemminger
  2010-10-05  6:25 ` Eric Dumazet
  2010-10-05  7:49 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2010-10-05  6:17 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

Another exported symbol only used in one file

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 include/net/addrconf.h |    2 --
 net/ipv6/addrconf.c    |    3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

--- a/include/net/addrconf.h	2010-10-02 09:04:22.700929104 +0900
+++ b/include/net/addrconf.h	2010-10-02 09:11:00.651004530 +0900
@@ -276,8 +276,6 @@ static inline int ipv6_addr_is_ll_all_ro
 		(addr->s6_addr32[3] ^ htonl(0x00000002))) == 0;
 }
 
-extern int __ipv6_isatap_ifid(u8 *eui, __be32 addr);
-
 static inline int ipv6_addr_is_isatap(const struct in6_addr *addr)
 {
 	return (addr->s6_addr32[2] | htonl(0x02000000)) == htonl(0x02005EFE);
--- a/net/ipv6/addrconf.c	2010-10-02 09:04:22.720901336 +0900
+++ b/net/ipv6/addrconf.c	2010-10-02 09:05:09.031021195 +0900
@@ -1544,7 +1544,7 @@ static int addrconf_ifid_infiniband(u8 *
 	return 0;
 }
 
-int __ipv6_isatap_ifid(u8 *eui, __be32 addr)
+static int __ipv6_isatap_ifid(u8 *eui, __be32 addr)
 {
 	if (addr == 0)
 		return -1;
@@ -1560,7 +1560,6 @@ int __ipv6_isatap_ifid(u8 *eui, __be32 a
 	memcpy(eui + 4, &addr, 4);
 	return 0;
 }
-EXPORT_SYMBOL(__ipv6_isatap_ifid);
 
 static int addrconf_ifid_sit(u8 *eui, struct net_device *dev)
 {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipv6: make __ipv6_isatap_ifid static
  2010-10-05  6:17 [PATCH net-next] ipv6: make __ipv6_isatap_ifid static Stephen Hemminger
@ 2010-10-05  6:25 ` Eric Dumazet
  2010-10-05  7:49 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2010-10-05  6:25 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: David Miller, netdev

Le mardi 05 octobre 2010 à 15:17 +0900, Stephen Hemminger a écrit :
> Another exported symbol only used in one file
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipv6: make __ipv6_isatap_ifid static
  2010-10-05  6:17 [PATCH net-next] ipv6: make __ipv6_isatap_ifid static Stephen Hemminger
  2010-10-05  6:25 ` Eric Dumazet
@ 2010-10-05  7:49 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-10-05  7:49 UTC (permalink / raw)
  To: shemminger; +Cc: netdev

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 5 Oct 2010 15:17:53 +0900

> Another exported symbol only used in one file
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-10-05  7:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05  6:17 [PATCH net-next] ipv6: make __ipv6_isatap_ifid static Stephen Hemminger
2010-10-05  6:25 ` Eric Dumazet
2010-10-05  7:49 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).