From: David Miller <davem@davemloft.net>
To: ole@ans.pl
Cc: fubar@us.ibm.com, bonding-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH 2/3] bonding: add Speed/Duplex information to /proc/net/bonding/bond
Date: Wed, 06 Oct 2010 14:24:24 -0700 (PDT) [thread overview]
Message-ID: <20101006.142424.246555203.davem@davemloft.net> (raw)
In-Reply-To: <4ca4b878.KGc4gLtXHLSFlAdV%ole@ans.pl>
From: Krzysztof Piotr Oledzki <ole@ans.pl>
Date: Thu, 30 Sep 2010 18:19:04 +0200
> Subject: bonding: add Speed/Duplex information to /proc/net/bonding/bond*
>
> Effect:
> Slave Interface: eth5
> MII Status: up
> Speed: 10000 Mbps
> Duplex: full
> Link Failure Count: 0
> Permanent HW addr: XX:XX:XX:XX:XX:XX
> Slave queue ID: 0
>
> Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>
Changing the layout of a procfs file is pretty much always unsafe.
Some useland program somewhere depends upon the current layout, and
therefore very likely could break if we change the contents.
We really can't apply a patch like this. A most portable and
extensible interface (netlink, ethtool) should be used to provide this
information to userspace.
next prev parent reply other threads:[~2010-10-06 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 16:19 [net-next-2.6 PATCH 2/3] bonding: add Speed/Duplex information to /proc/net/bonding/bond Krzysztof Piotr Oledzki
2010-10-06 21:24 ` David Miller [this message]
2010-10-06 21:32 ` Krzysztof Olędzki
2010-10-07 1:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006.142424.246555203.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).