From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: john.r.fastabend@intel.com, bhutchings@solarflare.com,
netdev@vger.kernel.org, therbert@google.com
Subject: Re: [net-next-2.6 PATCH] net: netif_set_real_num_rx_queues may cap num_rx_queues at init time
Date: Wed, 06 Oct 2010 23:35:25 -0700 (PDT) [thread overview]
Message-ID: <20101006.233525.02264748.davem@davemloft.net> (raw)
In-Reply-To: <1286432199.9417.47.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 07 Oct 2010 08:16:39 +0200
> Le lundi 04 octobre 2010 à 15:00 -0700, John Fastabend a écrit :
>> The logic for netif_set_real_num_rx_queues is the following,
>>
>
>
> ...
>
>> Because netif_set_real_num_rx_queues sets num_rx_queues if the
>> reg state is not NETREG_REGISTERED we end up with the incorrect
>> max number of rx queues. This patch proposes to remove the else
>> clause above so this does not occur. Also just reading the
>> function set_real_num it seems a bit unexpected that num_rx_queues
>> gets set.
>>
>> CC: Ben Hutchings <bhutchings@solarflare.com>
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>> ---
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-10-07 6:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 22:00 [net-next-2.6 PATCH] net: netif_set_real_num_rx_queues may cap num_rx_queues at init time John Fastabend
2010-10-05 5:35 ` Eric Dumazet
2010-10-05 16:08 ` John Fastabend
2010-10-05 16:34 ` Ben Hutchings
2010-10-05 17:45 ` John Fastabend
2010-10-06 14:52 ` John Fastabend
2010-10-06 15:07 ` Ben Hutchings
2010-10-06 15:20 ` John Fastabend
2010-10-06 15:23 ` Eric Dumazet
2010-10-06 15:31 ` Ben Hutchings
2010-10-06 18:14 ` Matt Carlson
2010-10-06 18:49 ` Eric Dumazet
2010-10-06 20:41 ` David Miller
2010-10-06 15:20 ` Eric Dumazet
2010-10-07 6:16 ` Eric Dumazet
2010-10-07 6:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006.233525.02264748.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).