From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@intel.com
Cc: jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, netdev@vger.kernel.org
Subject: Re: ixgbe: normalize frag_list usage
Date: Wed, 06 Oct 2010 23:58:37 -0700 (PDT) [thread overview]
Message-ID: <20101006.235837.241424681.davem@davemloft.net> (raw)
In-Reply-To: <80769D7B14936844A23C0C43D9FBCF0F25B97A24B5@orsmsx501.amr.corp.intel.com>
From: "Duyck, Alexander H" <alexander.h.duyck@intel.com>
Date: Tue, 5 Oct 2010 15:45:32 -0700
> The patch below is kind of what I had in mind for a way to do RSC and maintain
> the pointer scheme you are looking for. Consider this patch an RFC for now
> since I based this off of Jeff's internal testing tree and so it would need
> some modification to apply cleanly to net-next.
Can you really not remember the head somewhere?
What I wanted is for everyone to build their frag list SKBs from head to tail,
always. So that I could, as I mentioned in my original posting, do something
like:
struct sk_buff {
union {
struct list_head list;
struct {
struct sk_buff *frag_next;
struct sk_buff *frag_tail_tracker;
};
};
};
The ->frag_tail_tracker is only used in the head SKB to maintain where the
last SKB in the frag list is.
You're tracking the head from the inner SKBs, such that my intended
conventions are not being followed.
next prev parent reply other threads:[~2010-10-07 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 6:54 ixgbe: normalize frag_list usage David Miller
2010-10-04 15:37 ` Rose, Gregory V
2010-10-04 18:04 ` Alexander Duyck
2010-10-04 18:32 ` David Miller
2010-10-04 19:49 ` Alexander Duyck
2010-10-05 22:45 ` Duyck, Alexander H
2010-10-06 3:08 ` David Miller
2010-10-07 6:58 ` David Miller [this message]
2010-10-07 19:59 ` Alexander Duyck
2010-10-14 2:17 ` David Miller
2010-10-08 23:57 ` [RFC] ixgbe: v3 " Duyck, Alexander H
2010-10-25 19:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006.235837.241424681.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).