From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: dm@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH] remove leftover rcu_read_unlock calls from __mkroute_output
Date: Fri, 08 Oct 2010 10:51:26 -0700 (PDT) [thread overview]
Message-ID: <20101008.105126.48494137.davem@davemloft.net> (raw)
In-Reply-To: <1286513278.6536.470.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 08 Oct 2010 06:47:58 +0200
> Le jeudi 07 octobre 2010 à 17:48 -0700, Dimitris Michailidis a écrit :
>> Commit "fib: RCU conversion of fib_lookup()" removed rcu_read_lock() from
>> __mkroute_output but left a couple of calls to rcu_read_unlock() in there.
>> This causes lockdep to complain that the rcu_read_unlock() call in
>> __ip_route_output_key causes a lock inbalance and quickly crashes the
>> kernel. The below fixes this for me.
>>
>> Signed-off-by: Dimitris Michailidis <dm@chelsio.com>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-10-08 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 0:48 [PATCH] remove leftover rcu_read_unlock calls from __mkroute_output Dimitris Michailidis
2010-10-08 4:47 ` Eric Dumazet
2010-10-08 17:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101008.105126.48494137.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).