From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: lrodriguez@atheros.com, netdev@vger.kernel.org
Subject: Re: [PATCH] atl1c: Add support for Atheros AR8152 and AR8152
Date: Sun, 10 Oct 2010 21:03:04 -0700 (PDT) [thread overview]
Message-ID: <20101010.210304.71107535.davem@davemloft.net> (raw)
In-Reply-To: <1286759930.2955.285.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 11 Oct 2010 02:18:50 +0100
> Your commit 496c185c9495629ef1c65387cb2594578393cfe0 "atl1c: Add support
> for Atheros AR8152 and AR8152" included the following changes:
...
>> + if (hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b) {
...
>> + if ((hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)) {
...
> Shouldn't the first if-statement use the same condition as the second
> i.e. matching the previously-defined hardware types athr_l1c and
> athr_l2c?
Yeah that definitely looks like a bug to me.
next prev parent reply other threads:[~2010-10-11 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 1:18 [PATCH] atl1c: Add support for Atheros AR8152 and AR8152 Ben Hutchings
2010-10-11 4:03 ` David Miller [this message]
2010-10-11 18:48 ` Luis R. Rodriguez
2010-10-11 19:01 ` Stephen Hemminger
2010-10-11 19:02 ` David Miller
2010-10-11 22:28 ` Ben Hutchings
[not found] ` <20101012004503.GI10049@tux>
2010-10-22 20:37 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2010-02-12 0:33 Luis R. Rodriguez
2010-02-16 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010.210304.71107535.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=lrodriguez@atheros.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).