From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: phil@nwl.cc, netdev@vger.kernel.org, johann.baudy@gnu-log.net
Subject: Re: [PATCH] af_packet: account for VLAN when checking packet size
Date: Mon, 11 Oct 2010 09:01:53 -0700 (PDT) [thread overview]
Message-ID: <20101011.090153.226774563.davem@davemloft.net> (raw)
In-Reply-To: <1286805782.2737.25.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 11 Oct 2010 16:03:02 +0200
> If we dont test ETH_P_8021Q protocol here, we allow sending 1504 bytes
> frames for MTU=1500
>
> Should we really care ?
>
> If not, just do
>
> reserve = dev->hard_header_len + VLAN_HLEN;
Thats a good point, I think we need to validate the SKB protocol
field.
next prev parent reply other threads:[~2010-10-11 16:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 19:24 sending VLAN packets via packet_mmap Phil Sutter
2010-10-07 6:53 ` David Miller
2010-10-11 13:15 ` Phil Sutter
2010-10-11 13:25 ` [PATCH] af_packet: account for VLAN when checking packet size Phil Sutter
2010-10-11 14:03 ` Eric Dumazet
2010-10-11 16:01 ` David Miller [this message]
2010-10-11 17:29 ` Phil Sutter
2010-10-12 17:19 ` Michael S. Tsirkin
2010-10-12 17:40 ` David Miller
2010-10-22 8:41 ` Simon Horman
2010-10-27 15:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.090153.226774563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=johann.baudy@gnu-log.net \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).