From: David Miller <davem@davemloft.net>
To: inaky.perez-gonzalez@intel.com
Cc: jslaby@suse.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jirislaby@gmail.com,
linux-wimax@intel.com
Subject: Re: [PATCH 3/3] NET: wimax, fix use after free
Date: Mon, 11 Oct 2010 11:12:18 -0700 (PDT) [thread overview]
Message-ID: <20101011.111218.112596606.davem@davemloft.net> (raw)
In-Reply-To: <1286815606.21592.11.camel@localhost.localdomain>
From: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Date: Mon, 11 Oct 2010 09:46:46 -0700
> On Mon, 2010-10-11 at 02:26 -0700, Jiri Slaby wrote:
>> Stanse found that i2400m_rx frees skb, but still uses skb->len even
>> though it has skb_len defined. So use skb_len properly in the code.
>>
>> And also define it unsinged int rather than size_t to solve
>> compilation warnings.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>
> Ops, fail. Thanks for the catch. I assume you have compile tested it.
>
> Acked-by: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Applied.
next prev parent reply other threads:[~2010-10-11 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 9:26 [PATCH 1/3] NET: pch, fix use after free Jiri Slaby
2010-10-11 9:26 ` [PATCH 2/3] ATM: iphase, remove sleep-inside-atomic Jiri Slaby
2010-10-11 18:13 ` David Miller
2010-10-11 9:26 ` [PATCH 3/3] NET: wimax, fix use after free Jiri Slaby
2010-10-11 16:46 ` Inaky Perez-Gonzalez
2010-10-11 18:12 ` David Miller [this message]
2010-10-11 9:38 ` [PATCH 1/3] NET: pch, " Eric Dumazet
2010-10-11 18:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.111218.112596606.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=inaky.perez-gonzalez@intel.com \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).