From: David Miller <davem@davemloft.net>
To: jslaby@suse.cz
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@gmail.com, chas@cmf.nrl.navy.mil
Subject: Re: [PATCH 2/3] ATM: iphase, remove sleep-inside-atomic
Date: Mon, 11 Oct 2010 11:13:13 -0700 (PDT) [thread overview]
Message-ID: <20101011.111313.59678995.davem@davemloft.net> (raw)
In-Reply-To: <1286789218-13976-2-git-send-email-jslaby@suse.cz>
From: Jiri Slaby <jslaby@suse.cz>
Date: Mon, 11 Oct 2010 11:26:57 +0200
> Stanse found that ia_init_one locks a spinlock and inside of that it
> calls ia_start which calls:
> * request_irq
> * tx_init which does kmalloc(GFP_KERNEL)
>
> Both of them can thus sleep and result in a deadlock. I don't see a
> reason to have a per-device spinlock there which is used only there
> and inited right before the lock location. So remove it completely.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Applied.
next prev parent reply other threads:[~2010-10-11 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 9:26 [PATCH 1/3] NET: pch, fix use after free Jiri Slaby
2010-10-11 9:26 ` [PATCH 2/3] ATM: iphase, remove sleep-inside-atomic Jiri Slaby
2010-10-11 18:13 ` David Miller [this message]
2010-10-11 9:26 ` [PATCH 3/3] NET: wimax, fix use after free Jiri Slaby
2010-10-11 16:46 ` Inaky Perez-Gonzalez
2010-10-11 18:12 ` David Miller
2010-10-11 9:38 ` [PATCH 1/3] NET: pch, " Eric Dumazet
2010-10-11 18:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.111313.59678995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).