From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: lrodriguez@atheros.com, ben@decadent.org.uk,
Luis.Rodriguez@Atheros.com, netdev@vger.kernel.org,
Jie.Yang@atheros.com, linux-team@atheros.com
Subject: Re: [PATCH] atl1c: Add support for Atheros AR8152 and AR8152
Date: Mon, 11 Oct 2010 12:02:51 -0700 (PDT) [thread overview]
Message-ID: <20101011.120251.48500348.davem@davemloft.net> (raw)
In-Reply-To: <20101011120128.2cd460c9@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 11 Oct 2010 12:01:28 -0700
> On Mon, 11 Oct 2010 11:48:35 -0700
> "Luis R. Rodriguez" <lrodriguez@atheros.com> wrote:
>> @@ -132,7 +132,7 @@ static int atl1c_get_permanent_address(struct atl1c_hw *hw)
>> return -1;
>> }
>> /* Disable OTP_CLK */
>> - if ((hw->nic_type == athr_l1c || hw->nic_type == athr_l2c)) {
>> + if ((hw->nic_type == athr_l1c || hw->nic_type == athr_l2c_b)) {
>> otp_ctrl_data &= ~OTP_CTRL_CLK_EN;
>> AT_WRITE_REG(hw, REG_OTP_CTRL, otp_ctrl_data);
>> msleep(1);
>>
>
> Did you notice ((gratuitous extra parens))
Yeah let's kill that too while we're changing this.
next prev parent reply other threads:[~2010-10-11 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 1:18 [PATCH] atl1c: Add support for Atheros AR8152 and AR8152 Ben Hutchings
2010-10-11 4:03 ` David Miller
2010-10-11 18:48 ` Luis R. Rodriguez
2010-10-11 19:01 ` Stephen Hemminger
2010-10-11 19:02 ` David Miller [this message]
2010-10-11 22:28 ` Ben Hutchings
[not found] ` <20101012004503.GI10049@tux>
2010-10-22 20:37 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2010-02-12 0:33 Luis R. Rodriguez
2010-02-16 23:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.120251.48500348.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jie.Yang@atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=ben@decadent.org.uk \
--cc=linux-team@atheros.com \
--cc=lrodriguez@atheros.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).