From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: percpu net_device refcount
Date: Mon, 11 Oct 2010 12:13:44 -0700 (PDT) [thread overview]
Message-ID: <20101011.121344.260085789.davem@davemloft.net> (raw)
In-Reply-To: <1286471555.2912.291.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 07 Oct 2010 19:12:35 +0200
> We tried very hard to remove all possible dev_hold()/dev_put() pairs in
> network stack, using RCU conversions.
>
> There is still an unavoidable device refcount change for every dst we
> create/destroy, and this can slow down some workloads (routers or some
> app servers)
>
> We can switch to a percpu refcount implementation, now dynamic per_cpu
> infrastructure is mature. On a 64 cpus machine, this consumes 256 bytes
> per device.
...
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Ok, I'm fine with this.
But could you please get rid of that "#if 0" code block? The comment
is fine and should stay, but the commented out code shouldn't really
stay there.
Thanks!
next prev parent reply other threads:[~2010-10-11 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 17:12 [PATCH net-next] net: percpu net_device refcount Eric Dumazet
2010-10-07 17:30 ` Stephen Hemminger
2010-10-07 18:06 ` Eric Dumazet
2010-10-08 21:56 ` Paul E. McKenney
2010-10-09 6:23 ` Eric Dumazet
2010-10-09 16:58 ` Paul E. McKenney
2010-10-11 19:13 ` David Miller [this message]
2010-10-11 19:38 ` Eric Dumazet
2010-10-11 19:41 ` David Miller
2010-10-11 19:49 ` David Miller
2010-10-11 19:51 ` Eric Dumazet
2010-10-11 20:22 ` [PATCH net-next V3] " Eric Dumazet
2010-10-12 19:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.121344.260085789.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).