From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net dst: use a percpu_counter to track entries
Date: Mon, 11 Oct 2010 16:10:38 -0700 (PDT) [thread overview]
Message-ID: <20101011.161038.189691429.davem@davemloft.net> (raw)
In-Reply-To: <1286832573.30423.93.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 11 Oct 2010 23:29:33 +0200
> Le lundi 11 octobre 2010 à 13:07 -0700, David Miller a écrit :
>
>> When I first read the subject line for this patch, I was
>> scared, because I thought you were using a percpu counter
>> for dst entry refcounts :-)
>>
>> Anyways this is fine, applied, thanks!
>
> I though about a crazy idea for loopback device (but not a percpu
> counter for dst refcounts)
>
> Add a cpu field somewhere so that each cpu manipulates a different dst.
>
> Or maybe just never cache such dst, so that each tcp socket uses its own
> dst.
We could even make the cpu (in lieu of a socket) a key in the lookup,
but that would complicate handling things like PMTU indications and
redirects.
prev parent reply other threads:[~2010-10-11 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 16:37 [PATCH net-next] net dst: use a percpu_counter to track entries Eric Dumazet
2010-10-11 20:07 ` David Miller
2010-10-11 21:29 ` Eric Dumazet
2010-10-11 23:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101011.161038.189691429.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).