From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch 2/2] vhost: fix return code for log_access_ok() Date: Mon, 11 Oct 2010 19:24:19 +0200 Message-ID: <20101011172419.GG5851@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Juan Quintela , "David S. Miller" , Rusty Russell , kvm@vger.kernel.org, virtualization@lists.osdl.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org access_ok() returns 1 if it's OK otherwise it should return 0. Signed-off-by: Dan Carpenter diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c2aa12c..f82fe57 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -371,7 +371,7 @@ static int log_access_ok(void __user *log_base, u64 addr, unsigned long sz) /* Make sure 64 bit math will not overflow. */ if (a > ULONG_MAX - (unsigned long)log_base || a + (unsigned long)log_base > ULONG_MAX) - return -EFAULT; + return 0; return access_ok(VERIFY_WRITE, log_base + a, (sz + VHOST_PAGE_SIZE * 8 - 1) / VHOST_PAGE_SIZE / 8);